Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 )
Change subject: [KUDU-3452] Make validate table creating task not affected ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/19594/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19594/12//COMMIT_MSG@15 PS12, Line 15: other left tablets have no : chance to be created. nit: will not try to select replicas for other PREPARING tablets. http://gerrit.cloudera.org:8080/#/c/19594/12/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19594/12/src/kudu/tools/kudu-tool-test.cc@9367 PS12, Line 9367: TEST_F(ToolTest, TestNotAffectedCreatingTables) { This test also has nothing to do with kudu tools. Maybe move this test to create-table-itest.cc? -- To view, visit http://gerrit.cloudera.org:8080/19594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9 Gerrit-Change-Number: 19594 Gerrit-PatchSet: 12 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 04 May 2023 16:33:11 +0000 Gerrit-HasComments: Yes
