Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 )
Change subject: [KUDU-3452] Make validate table creating task not affected ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/19594/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19594/12//COMMIT_MSG@15 PS12, Line 15: will not try to select replicas : for other PREPARING t > nit: will not try to select replicas for other PREPARING tablets. Done http://gerrit.cloudera.org:8080/#/c/19594/12/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19594/12/src/kudu/tools/kudu-tool-test.cc@9367 PS12, Line 9367: TEST_F(ToolTest, TestNotAffectedCreatingTables) { > This test also has nothing to do with kudu tools. Maybe move this test to c This unit test is a litter complicated, it needs to the health of the tables by CLI. And it needs to check the status of tablet servers when restarting them. Using CLI is more convenient. -- To view, visit http://gerrit.cloudera.org:8080/19594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9 Gerrit-Change-Number: 19594 Gerrit-PatchSet: 13 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 05 May 2023 03:27:29 +0000 Gerrit-HasComments: Yes
