Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 )
Change subject: [KUDU-3452] Make validate table creating task not affected ...................................................................... Patch Set 10: (13 comments) http://gerrit.cloudera.org:8080/#/c/19594/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19594/9//COMMIT_MSG@9 PS9, Line 9: th RF=n when th > times out Done http://gerrit.cloudera.org:8080/#/c/19594/9//COMMIT_MSG@9 PS9, Line 9: Curren > Creating Done http://gerrit.cloudera.org:8080/#/c/19594/9//COMMIT_MSG@9 PS9, Line 9: number of : healthy tserve > ? Looks like an unfinished sentence Done http://gerrit.cloudera.org:8080/#/c/19594/9//COMMIT_MSG@10 PS9, Line 10: is less than n will get stuck. Because : catalog manager creates tablets for it will fail and retry : continuou > I'm not sure I understand where that two-replica table request appears from Here is an example. I mean currently, creating a table with RF=n when the number of healthy tservers is less than n will get stuck. Because catalog manager creates tablets for it will fail and retry continuously. At the same time, creating a table with RF=m also will get stuck even if there are more than m healthy tservers. Because catalog manager will return when finds a tablet-creating task failed and other left tablets have no chance to be created. http://gerrit.cloudera.org:8080/#/c/19594/9//COMMIT_MSG@15 PS9, Line 15: failed > Why that's a problem? Was it a problem when the system didn't allow to cre Creating a table with RF=n when the number of healthy tservers is less than n will get stuck. Because catalog manager creates tablets for it will fail and retry continuously. At the same time, creating a table with RF=m also will get stuck even if there are more than m healthy tservers. Because catalog manager will return when finds a tablet-creating task failed and other left tablets have no chance to be created. http://gerrit.cloudera.org:8080/#/c/19594/9//COMMIT_MSG@15 PS9, Line 15: tin > fixes Done http://gerrit.cloudera.org:8080/#/c/19594/9/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19594/9/src/kudu/master/catalog_manager.cc@5933 PS9, Line 5933: > the catalog manager has selected replicas for the tablet Done http://gerrit.cloudera.org:8080/#/c/19594/9/src/kudu/master/catalog_manager.cc@5934 PS9, Line 5934: > If selecting replicas for the tablet fails Done http://gerrit.cloudera.org:8080/#/c/19594/9/src/kudu/master/catalog_manager.cc@5940 PS9, Line 5940: } : } > nit: please use Substitute() to format the error message -- it's much easie Done http://gerrit.cloudera.org:8080/#/c/19594/9/src/kudu/master/catalog_manager.cc@5943 PS9, Line 5943: // Nothing to do : if (deferred.tablets_to_add.empty() && : d > readability nit: it's much easier to read if the condition with the shorter Done http://gerrit.cloudera.org:8080/#/c/19594/9/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/19594/9/src/kudu/tools/kudu-admin-test.cc@1938 PS9, Line 1938: ange parti > heartbeat Done http://gerrit.cloudera.org:8080/#/c/19594/9/src/kudu/tools/kudu-admin-test.cc@1952 PS9, Line 1952: _val STRING > should succeed Done http://gerrit.cloudera.org:8080/#/c/19594/9/src/kudu/tools/kudu-admin-test.cc@1964 PS9, Line 1964: tions, and n > should succeed Done -- To view, visit http://gerrit.cloudera.org:8080/19594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9 Gerrit-Change-Number: 19594 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 07:50:59 +0000 Gerrit-HasComments: Yes
