Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19890 )
Change subject: [tools]KUDU-1945: Kudu copy table tool ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19890/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19890/2//COMMIT_MSG@7 PS2, Line 7: ]K nit: Add a blank space. http://gerrit.cloudera.org:8080/#/c/19890/2/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/19890/2/src/kudu/tools/table_scanner.cc@873 PS2, Line 873: int auto_incrementing_col_idx = table->schema().GetAutoIncrementingColumnIndex(); nit: how about adding 'const' ? -- To view, visit http://gerrit.cloudera.org:8080/19890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754a7e84c16d1f3b2d52be937e1eb50b3d00d759 Gerrit-Change-Number: 19890 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 15 May 2023 10:14:33 +0000 Gerrit-HasComments: Yes
