Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19890 )
Change subject: [tools] KUDU-1945: Kudu copy table and per loadgen ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/19890/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19890/2/src/kudu/tools/kudu-tool-test.cc@5737 PS2, Line 5737: > Is this a typo? Yes, fixed in PS3 http://gerrit.cloudera.org:8080/#/c/19890/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19890/3/src/kudu/tools/kudu-tool-test.cc@870 PS3, Line 870: // In kTestCopyTableSchemaOnly and kTestCopyTableAutoIncrementingColumn : // case, we may create table with RF > nit: update the comment correspondingly? Yes, will do. It is not crucial to have but in case of scanning non-leader replicas, this helps to catch if there are any inconsistencies in auto incrementing columns (although we do have separate tests for that). http://gerrit.cloudera.org:8080/#/c/19890/3/src/kudu/tools/kudu-tool-test.cc@1207 PS3, Line 1207: RETURN_NOT_OK(b. > Should handle the return code? Ah, yes. Will do. -- To view, visit http://gerrit.cloudera.org:8080/19890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754a7e84c16d1f3b2d52be937e1eb50b3d00d759 Gerrit-Change-Number: 19890 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 19 May 2023 07:48:31 +0000 Gerrit-HasComments: Yes
