Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19890 )
Change subject: [tools] KUDU-1945: Kudu copy table and per loadgen ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/19890/3/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/19890/3/src/kudu/tools/table_scanner.cc@753 PS3, Line 753: // If we are copying a table we do not want to scan the auto-incrementing column > nit: adding the WHY part to this comment would be great Done http://gerrit.cloudera.org:8080/#/c/19890/3/src/kudu/tools/table_scanner.cc@882 PS3, Line 882: f (auto_incrementi > I'm not sure the intermix of 'i' and 'j' results in correct outcode eventua Yep good point. Fixed it now. http://gerrit.cloudera.org:8080/#/c/19890/3/src/kudu/tools/table_scanner.cc@882 PS3, Line 882: col_idx != dst_iter > Should handle the return Status code? Done http://gerrit.cloudera.org:8080/#/c/19890/3/src/kudu/tools/table_scanner.cc@883 PS3, Line 883: src_row.IsNu > ditto Done -- To view, visit http://gerrit.cloudera.org:8080/19890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754a7e84c16d1f3b2d52be937e1eb50b3d00d759 Gerrit-Change-Number: 19890 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 19 May 2023 07:49:22 +0000 Gerrit-HasComments: Yes
