Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19899 )
Change subject: KUDU-3413 [multi-tenancy] add some renames for multi-tenancy ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/19899/4/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/19899/4/src/kudu/fs/fs_manager.cc@508 PS4, Line 508: encryption_key It should be a 'decrypted key' because it is decrypted from an encrypted key by DecryptEncryptedKey() ? http://gerrit.cloudera.org:8080/#/c/19899/4/src/kudu/fs/key_provider.h File src/kudu/fs/key_provider.h: http://gerrit.cloudera.org:8080/#/c/19899/4/src/kudu/fs/key_provider.h@38 PS4, Line 38: encrypted nit: duplicatd? http://gerrit.cloudera.org:8080/#/c/19899/4/src/kudu/fs/ranger_kms_key_provider.h File src/kudu/fs/ranger_kms_key_provider.h: http://gerrit.cloudera.org:8080/#/c/19899/4/src/kudu/fs/ranger_kms_key_provider.h@40 PS4, Line 40: encryption_key Corresponding to https://gerrit.cloudera.org/c/19899/4/src/kudu/fs/key_provider.h#33, it should be "decrypted_key" ? http://gerrit.cloudera.org:8080/#/c/19899/4/src/kudu/fs/ranger_kms_key_provider.cc File src/kudu/fs/ranger_kms_key_provider.cc: http://gerrit.cloudera.org:8080/#/c/19899/4/src/kudu/fs/ranger_kms_key_provider.cc@30 PS4, Line 30: encryption_key Corresponding to https://gerrit.cloudera.org/c/19899/4/src/kudu/fs/key_provider.h#33, it should be "decrypted_key" ? http://gerrit.cloudera.org:8080/#/c/19899/4/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/19899/4/src/kudu/tools/tool_action_common.cc@975 PS4, Line 975: encryption_key nit: decrypted_key ? -- To view, visit http://gerrit.cloudera.org:8080/19899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5bf51df9e7b9ebdaeb353049274cb18fa73a43a Gerrit-Change-Number: 19899 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 18 May 2023 16:36:00 +0000 Gerrit-HasComments: Yes
