Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19899 )
Change subject: KUDU-3413 [multi-tenancy] add some renames for multi-tenancy ...................................................................... Patch Set 5: (17 comments) It seems there is some confusion between encryption/encrypted key in the naming of the methods. I left a few suggestions to make it more consistent. Well, at least it would look more consistent to me with the updated naming :) Thanks! http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider-test.cc File src/kudu/fs/default_key_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider-test.cc@42 PS5, Line 42: GenerateEncryptedKey GenerateEncryptionKey ? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider-test.cc@43 PS5, Line 43: DecryptEncryptedKey DecryptEncryptionKey ? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider.h File src/kudu/fs/default_key_provider.h: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider.h@33 PS5, Line 33: DecryptEncryptedKey DecryptEncryptionKey ? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider.h@53 PS5, Line 53: GenerateEncryptedKey GenerateEncryptionKey ? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/fs_manager.cc@509 PS5, Line 509: DecryptEncryptedKey DecryptEncryptionKey ? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/key_provider.h File src/kudu/fs/key_provider.h: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/key_provider.h@27 PS5, Line 27: encrypted nit: encryption http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/key_provider.h@33 PS5, Line 33: DecryptEncryptedKey DecryptEncryptionKey or just DecryptKey ? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/key_provider.h@38 PS5, Line 38: Generates an encrypted key. Generates an encryption key (the generated key is encrypted). http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/key_provider.h@39 PS5, Line 39: GenerateEncryptedKey GenerateEncryptionKey or just GenerateKey? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.h File src/kudu/fs/ranger_kms_key_provider.h: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.h@37 PS5, Line 37: DecryptEncryptedKey DecryptEncryptionKey or just DecryptKey? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.h@42 PS5, Line 42: Generates an encrypted key. Generates a key for encryption. The generated key is encrypted. http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.h@43 PS5, Line 43: GenerateEncryptedKey GenerateEncryptionKey or just GenerateKey? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.cc File src/kudu/fs/ranger_kms_key_provider.cc: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.cc@27 PS5, Line 27: DecryptEncryptedKey DecryptEncryptionKey or DecryptKey ? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.cc@34 PS5, Line 34: GenerateEncryptedKey GenerateEncryptionKey or just GenerateKey ? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.cc@37 PS5, Line 37: GenerateEncryptedKey GenerateEncryptionKey or GenerateKey ? http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/mini-cluster/external_mini_cluster.cc@1380 PS5, Line 1380: DecryptEncryptedKey DecryptEncryptionKey http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/ranger-kms/ranger_kms_client.h File src/kudu/ranger-kms/ranger_kms_client.h: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/ranger-kms/ranger_kms_client.h@40 PS5, Line 40: GenerateEncryptedKey GenerateEncryptionKey -- To view, visit http://gerrit.cloudera.org:8080/19899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5bf51df9e7b9ebdaeb353049274cb18fa73a43a Gerrit-Change-Number: 19899 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 21 May 2023 04:37:07 +0000 Gerrit-HasComments: Yes
