KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19899 )
Change subject: KUDU-3413 [multi-tenancy] add some renames for multi-tenancy ...................................................................... Patch Set 6: (17 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider-test.cc File src/kudu/fs/default_key_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider-test.cc@42 PS5, Line 42: GenerateEncryptionKe > GenerateEncryptionKey ? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider-test.cc@43 PS5, Line 43: DecryptEncryptionKe > DecryptEncryptionKey ? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider.h File src/kudu/fs/default_key_provider.h: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider.h@33 PS5, Line 33: DecryptEncryptionKe > DecryptEncryptionKey ? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/default_key_provider.h@53 PS5, Line 53: GenerateEncryptionKe > GenerateEncryptionKey ? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/fs_manager.cc@509 PS5, Line 509: DecryptEncryptionKe > DecryptEncryptionKey ? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/key_provider.h File src/kudu/fs/key_provider.h: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/key_provider.h@27 PS5, Line 27: encryptio > nit: encryption Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/key_provider.h@33 PS5, Line 33: DecryptEncryptionKe > DecryptEncryptionKey or just DecryptKey ? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/key_provider.h@38 PS5, Line 38: Generates an encryption key > Generates an encryption key (the generated key is encrypted). Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/key_provider.h@39 PS5, Line 39: GenerateEncryptionKe > GenerateEncryptionKey or just GenerateKey? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.h File src/kudu/fs/ranger_kms_key_provider.h: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.h@37 PS5, Line 37: DecryptEncryptionKe > DecryptEncryptionKey or just DecryptKey? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.h@42 PS5, Line 42: Generates an encryption key > Generates a key for encryption. The generated key is encrypted. Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.h@43 PS5, Line 43: GenerateEncryptionKe > GenerateEncryptionKey or just GenerateKey? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.cc File src/kudu/fs/ranger_kms_key_provider.cc: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.cc@27 PS5, Line 27: DecryptEncryptionKe > DecryptEncryptionKey or DecryptKey ? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.cc@34 PS5, Line 34: GenerateEncryptionKe > GenerateEncryptionKey or just GenerateKey ? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/fs/ranger_kms_key_provider.cc@37 PS5, Line 37: GenerateEncryptionKe > GenerateEncryptionKey or GenerateKey ? Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/mini-cluster/external_mini_cluster.cc@1380 PS5, Line 1380: DecryptEncryptionKe > DecryptEncryptionKey Done http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/ranger-kms/ranger_kms_client.h File src/kudu/ranger-kms/ranger_kms_client.h: http://gerrit.cloudera.org:8080/#/c/19899/5/src/kudu/ranger-kms/ranger_kms_client.h@40 PS5, Line 40: GenerateEncryptionKe > GenerateEncryptionKey Done -- To view, visit http://gerrit.cloudera.org:8080/19899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5bf51df9e7b9ebdaeb353049274cb18fa73a43a Gerrit-Change-Number: 19899 Gerrit-PatchSet: 6 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 22 May 2023 02:19:06 +0000 Gerrit-HasComments: Yes
