Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19890 )
Change subject: [tools] KUDU-1945: Kudu table copy and perf loadgen ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/19890/6/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/19890/6/src/kudu/tools/table_scanner.cc@770 PS6, Line 770: DCHECK(dst_table->schema() == src_table->schema()); OK, that's just a verification for DEBUG builds. It's absent if building release version of the binaries. DCHECK() makes sense on things which are related to the code paths but don't change with varying the data. Here it's something else. -- To view, visit http://gerrit.cloudera.org:8080/19890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754a7e84c16d1f3b2d52be937e1eb50b3d00d759 Gerrit-Change-Number: 19890 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 23 May 2023 07:33:06 +0000 Gerrit-HasComments: Yes
