Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 )
Change subject: [KUDU-3452] A tool to report on table creation progress ...................................................................... Patch Set 12: (6 comments) http://gerrit.cloudera.org:8080/#/c/19584/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19584/12//COMMIT_MSG@17 PS12, Line 17: This patch adds a new flag: --show_in_flight_tables : for command: 'kudu table list' to show the creating tables. The description should be updated. http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/master/catalog_manager.h@727 PS12, Line 727: Status ListInFlightTables(const ListInFlightTablesRequestPB* req, nit: Please add comments for this method. http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/master/catalog_manager.cc@3958 PS12, Line 3958: if (!tablet_lock.data().is_creating()) { : continue; : } : num_tablets_in_flight++; nit: Simplify this to if (tablet_lock.data().is_creating()) { num_tablets_in_flight++; } http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/master/catalog_manager.cc@3989 PS12, Line 3989: nit: Remove this blank line. http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/master/master.proto@630 PS12, Line 630: repeated TableInfo tables = 2; nit: please add comments for this field. http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/tools/kudu-tool-test.cc@9496 PS12, Line 9496: ASSERT_STR_CONTAINS(stdout, : "\"num_tablets_in_flight\": 1,\n \"state\": \"RUNNING\"\n"); : ASSERT_STR_CONTAINS(stdout, : "\"num_tablets_in_flight\": 1,\n \"state\": \"ALTERING\"\n"); nit: Should we also check the output of ' kNotEnoughTServersTableName' and 'kAddNewPartitionTableName' separately? -- To view, visit http://gerrit.cloudera.org:8080/19584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5 Gerrit-Change-Number: 19584 Gerrit-PatchSet: 12 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 30 May 2023 15:17:18 +0000 Gerrit-HasComments: Yes
