Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19584 )

Change subject: [KUDU-3452] A tool to report on table creation progress
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19584/9//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19584/9//COMMIT_MSG@14
PS9, Line 14: And users
            : can decide to cancel the creating tasks or not.
I don't think there is such a tool for users to cancel the creating task. Maybe 
remove this sentence?

Also curious about how to fix this problem even if we could filter out tablets 
in 'CREATING' state. Seems we can only wait for creating tasks to succeed or 
drop these tables.


http://gerrit.cloudera.org:8080/#/c/19584/9/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/19584/9/src/kudu/tools/tool_action_table.cc@242
PS9, Line 242: FLAGS_show_in_flight_tables &&
             :       (FLAGS_list_tablets || FLAGS_show_tablet_partition_info ||
             :       FLAGS_show_hash_partition_info || FLAGS_show_table_info)
Since this flag changes the tool's behavior and cannot be used with other 
flags, how about adding a new tool?



--
To view, visit http://gerrit.cloudera.org:8080/19584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5
Gerrit-Change-Number: 19584
Gerrit-PatchSet: 9
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Tue, 23 May 2023 01:40:14 +0000
Gerrit-HasComments: Yes

Reply via email to