Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 )
Change subject: [KUDU-3452] A tool to report on table creation progress ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/19584/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19584/14//COMMIT_MSG@18 PS14, Line 18: will show nit: lists http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/master/master.proto@630 PS12, Line 630: repeated TableInfo tables = 2; > Done This field still lacks comments in PS14. http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19584/12/src/kudu/tools/kudu-tool-test.cc@9496 PS12, Line 9496: ASSERT_STR_CONTAINS(stdout, : "\"num_tablets_in_flight\": 1,\n \"state\": \"RUNNING\"\n"); : ASSERT_STR_CONTAINS(stdout, : "\"num_tablets_in_flight\": 1,\n \"state\": \"ALTERING\"\n"); > The format of stdout is like the following, it contains a field 'id' which It seems that we check the output for each table when the output format is 'pretty' or 'json_compact' format, and also check whether the output contains an unknown table. Why not do the same check for the 'json' format? -- To view, visit http://gerrit.cloudera.org:8080/19584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5 Gerrit-Change-Number: 19584 Gerrit-PatchSet: 14 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 31 May 2023 09:28:21 +0000 Gerrit-HasComments: Yes
