Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19910 )
Change subject: [jwt] switching JWT verification to KeyBasedJwtVerifier ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/19910/16/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/19910/16/src/kudu/server/server_base.cc@257 PS16, Line 257: DEFINE_string(jwks_file_path, "", : "File path of the pre-installed JSON Web Key Set (JWKS) for JWT verification."); : TAG_FLAG(jwks_file_path, experimental); BTW (not exactly a part of this changelist, but anyways), I want to share my observation. I didn't find any end-to-end test where a mini-cluster uses JWKS information specified by this --jwks_file_path, but maybe I'm missing something. http://gerrit.cloudera.org:8080/#/c/19910/16/src/kudu/util/jwt-util.h File src/kudu/util/jwt-util.h: http://gerrit.cloudera.org:8080/#/c/19910/16/src/kudu/util/jwt-util.h@117 PS16, Line 117: bool is_local_file, > I'm not sure I understand why we need this parameter once a new constructor Same for JWTHelper::Init() -- To view, visit http://gerrit.cloudera.org:8080/19910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f166807bfcf7051bda7843e186eacfbe379eba Gerrit-Change-Number: 19910 Gerrit-PatchSet: 16 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 05 Jun 2023 19:52:48 +0000 Gerrit-HasComments: Yes
