Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 )
Change subject: KUDU-3452 A tool to report on table creation progress ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/19584/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19584/18//COMMIT_MSG@7 PS18, Line 7: KUDU-3452 A tool to report on table creation progress > nit: no need for the square brackets when mentioning a JIRA. Done http://gerrit.cloudera.org:8080/#/c/19584/18//COMMIT_MSG@18 PS18, Line 18: This patch adds a new command: 'kudu table list_in_flight' > should we also add an in-flight column to the existing table list command a This command is a separated command, it does not belongs the command table list. http://gerrit.cloudera.org:8080/#/c/19584/18/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19584/18/src/kudu/master/master.proto@625 PS18, Line 625: int32 > nit: Should this also be 'uint32'? Yes, it should be. But in client.proto line 544, the filed num_tablets has been defined as int32. To reduce the code modification, we can just keep it as int32, it is not a big problem. -- To view, visit http://gerrit.cloudera.org:8080/19584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5 Gerrit-Change-Number: 19584 Gerrit-PatchSet: 19 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 05 Jun 2023 14:38:55 +0000 Gerrit-HasComments: Yes
