Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 )
Change subject: [KUDU-3452] A tool to report on table creation progress ...................................................................... Patch Set 17: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/tools/kudu-tool-test.cc@9376 PS15, Line 9376: static vector<string> TableListFormats() { : return { "pretty", "json", "json_compact" }; : } > I have tried to use this solution. but the LINT test reports a error: `For I see. It wants you to use char or char* variables, and you could try to do so, but then it would be necessary to use C-style string comparison functions in the code. OK, let it be as is -- that's just a nit anyways. http://gerrit.cloudera.org:8080/#/c/19584/15/src/kudu/tools/kudu-tool-test.cc@9420 PS15, Line 9420: .Create(); : }; : // Create a table and delete it to prove this CLI command will not list deleted tables. : { : > This case is necessary to prove that this CLI command will not list a delet Thank you for the clarification! Then it seems ASSERT_STR_NOT_CONTAINS(stdout, kNeedDeleteTable) is missing around line 9482 in PS17? Does it make sense to add that extra check? -- To view, visit http://gerrit.cloudera.org:8080/19584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5 Gerrit-Change-Number: 19584 Gerrit-PatchSet: 17 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 02 Jun 2023 14:11:30 +0000 Gerrit-HasComments: Yes
