Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 )
Change subject: [KUDU-3452] A tool to report on table creation progress ...................................................................... Patch Set 17: Code-Review+1 (4 comments) LGTM. Just s couple of minor comments. http://gerrit.cloudera.org:8080/#/c/19584/17/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19584/17/src/kudu/master/catalog_manager.cc@3955 PS17, Line 3955: int num_tablets_in_flight nit: this can be an unsigned int. http://gerrit.cloudera.org:8080/#/c/19584/17/src/kudu/master/catalog_manager.cc@3968 PS17, Line 3968: <= nit: check for '==' if num_tablets_in_flight is unsigned http://gerrit.cloudera.org:8080/#/c/19584/17/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19584/17/src/kudu/master/master.proto@625 PS17, Line 625: optional int32 num_tablets = 3; : optional int32 num_tablets_in_flight = 4; nit: is there a reason for declaring these signed integers? Can we declare these as uint32 instead? http://gerrit.cloudera.org:8080/#/c/19584/17/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/19584/17/src/kudu/tools/tool.proto@548 PS17, Line 548: int32 nit: same comment. int32 vs uint32 ? -- To view, visit http://gerrit.cloudera.org:8080/19584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5 Gerrit-Change-Number: 19584 Gerrit-PatchSet: 17 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 02 Jun 2023 14:15:22 +0000 Gerrit-HasComments: Yes
