Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19910 )
Change subject: [jwt] switching JWT verification to KeyBasedJwtVerifier ...................................................................... Patch Set 18: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/19910/16/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/19910/16/src/kudu/server/server_base.cc@257 PS16, Line 257: DEFINE_string(jwks_file_path, "", : "File path of the pre-installed JSON Web Key Set (JWKS) for JWT verification."); : TAG_FLAG(jwks_file_path, experimental); > Right, the jwks_file_path was intended for tests originally, so that we're Yep, I think an extra test there wouldn't hurt, certainly. Probably, addressing it in a separate patch will do just fine. -- To view, visit http://gerrit.cloudera.org:8080/19910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f166807bfcf7051bda7843e186eacfbe379eba Gerrit-Change-Number: 19910 Gerrit-PatchSet: 18 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 06 Jun 2023 16:50:54 +0000 Gerrit-HasComments: Yes
