Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19910 )
Change subject: [jwt] switching JWT verification to KeyBasedJwtVerifier ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/19910/16/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/19910/16/src/kudu/server/server_base.cc@a798 PS16, Line 798: > PerAccountKeyBasedJwtVerifier is tests only currently, it could be used lat I didn't see a comment as of PS18, but I guess you can add it later on in a follow-up patch. It's not going to affect any functionality (of course), but it would be nice to have a comment about that. If you are up to adding an extra test that have been discussed at https://gerrit.cloudera.org/#/c/19910/16/src/kudu/server/server_base.cc@259, you can add the comment as well in there. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/19910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f166807bfcf7051bda7843e186eacfbe379eba Gerrit-Change-Number: 19910 Gerrit-PatchSet: 16 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 06 Jun 2023 18:11:51 +0000 Gerrit-HasComments: Yes
