Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19918 )
Change subject: [java] add buffer space limit for KuduSession ...................................................................... Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/19918/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19918/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@751 PS5, Line 751: (activeBufferOps + 1 >= mutationBufferMaxOps || : isAboveMaxSize(activeBufferSize + operation.getRow().size() > I'm afraid doing so will make the code more complex. At present, the logic Sorry I didn't get the point of how can it be more complex. If add a function like: boolean needFlush(int activeBufferOps, long activeBufferSize) { ... } the caller here is: if (needFlush(activeBufferOps + 1, activeBufferSize + operation.getRow().size()) && inactiveBufferAvailable()) { ... } -- To view, visit http://gerrit.cloudera.org:8080/19918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I312d47c98566f9405361d969a4b68b326bb3c4d9 Gerrit-Change-Number: 19918 Gerrit-PatchSet: 6 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 14 Jun 2023 08:10:38 +0000 Gerrit-HasComments: Yes
