KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19918 )
Change subject: [java] add buffer space limit for KuduSession ...................................................................... Patch Set 7: (7 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/19918/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19918/6//COMMIT_MSG@11 PS6, Line 11: buffer space > buffer space Done http://gerrit.cloudera.org:8080/#/c/19918/6//COMMIT_MSG@11 PS6, Line 11: configuring > nit: configuring Same spelling? http://gerrit.cloudera.org:8080/#/c/19918/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19918/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@751 PS5, Line 751: : > Sorry I didn't get the point of how can it be more complex. If add a functi Sorry for misunderstood your meaning at the beginning. I have re implemented this part of the logic according to your suggestion. http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@649 PS6, Line 649: isExcessMaxSiz > what about isExcessMaxSize ? Done http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@894 PS6, Line 894: flu > nit: from Done http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java@410 PS6, Line 410: assertFalse(resp.hasRowError()); > How about use assertEventuallyTrue? Done http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java@410 PS6, Line 410: assertFalse(resp.hasRowError()); > If session.hasPendingOperations() is always true, it will be an infinity lo Done -- To view, visit http://gerrit.cloudera.org:8080/19918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I312d47c98566f9405361d969a4b68b326bb3c4d9 Gerrit-Change-Number: 19918 Gerrit-PatchSet: 7 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 15 Jun 2023 03:44:15 +0000 Gerrit-HasComments: Yes
