Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19918 )
Change subject: [java] add buffer space limit for KuduSession ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/19918/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19918/6//COMMIT_MSG@11 PS6, Line 11: configuring nit: configuring http://gerrit.cloudera.org:8080/#/c/19918/6//COMMIT_MSG@11 PS6, Line 11: Buffer Space buffer space http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@649 PS6, Line 649: isAboveMaxSize what about isExcessMaxSize ? http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@894 PS6, Line 894: with nit: from http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19918/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java@410 PS6, Line 410: while (session.hasPendingOperations()) { If session.hasPendingOperations() is always true, it will be an infinity loop. Our expecting is session.hasPendingOperations() = false very soon. So should give it a limit time, assertEventuallyTrue is ok. I think you can comments why sleep to wait at this -- To view, visit http://gerrit.cloudera.org:8080/19918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I312d47c98566f9405361d969a4b68b326bb3c4d9 Gerrit-Change-Number: 19918 Gerrit-PatchSet: 6 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 14 Jun 2023 08:39:26 +0000 Gerrit-HasComments: Yes
