Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19931 )
Change subject: KUDU-3476: Make replica placement range and table aware ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/integration-tests/create-table-itest.cc File src/kudu/integration-tests/create-table-itest.cc: http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/integration-tests/create-table-itest.cc@484 PS10, Line 484: if (table.first == "table1") { : ASSERT_EQ(6, ranges.second); : } else { : ASSERT_EQ(3, ranges.second); nit: Maybe add a comment on how did we arrive at these numbers? http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/master/master.proto@338 PS10, Line 338: message TabletsByRangePB { > Would be great to add comments for these two new structures as well. +1 http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/master/master_service.cc@459 PS10, Line 459: for (auto it = req->num_live_tablets_by_range_and_table().begin(); Do we want to keep a track of this information even if the flag "--enable_range_replica_placement" is set to false? Same from tablet server side. -- To view, visit http://gerrit.cloudera.org:8080/19931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9caeb8d5547e946bfeb152a99e1ec034c3fa0a0f Gerrit-Change-Number: 19931 Gerrit-PatchSet: 10 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Wed, 28 Jun 2023 23:19:42 +0000 Gerrit-HasComments: Yes
