Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19931 )
Change subject: KUDU-3476: Make replica placement range and table aware ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/tserver/ts_tablet_manager.h@222 PS10, Line 222: RUNNING or BOOTSTRAPPING > Maybe this will help: I think there isn't any other state except for RUNNING, BOOTSTRAPPING, INITIALIZED we need to take into account in those calculations. But there is one important fact we need to take into consideration. After looking into the details, it seems the presence of tombstoned tablet replicas makes it a little bit more complicated if we want to take into account tablets in INITIALIZED state. Basically, if a tablet replica's is INITIALIZED, we also need to check its data state to tell between a tablet to be bootstrapped and initially changing its state to RUNNING, and a tablet replica that's tombstoned and will stay in INITIALIZED state indefinitely (or until it's copied over, bootstrapped and become running again). For details, you can check out TSTabletManager::HandleNonReadyTabletOnStartup() and TSTabletManager::Init() work. With that, it's completely fine with me if in this patch we just count in RUNNING and BOOTSTRAPPING tablets, and we can address that rare use-case with a tablet server that bootstraps its replicas in a follow-up patch. -- To view, visit http://gerrit.cloudera.org:8080/19931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9caeb8d5547e946bfeb152a99e1ec034c3fa0a0f Gerrit-Change-Number: 19931 Gerrit-PatchSet: 10 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Fri, 30 Jun 2023 00:31:05 +0000 Gerrit-HasComments: Yes
