Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19931 )
Change subject: KUDU-3476: Make replica placement range and table aware ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/master/master_service.cc@459 PS10, Line 459: for (auto it = req->num_live_tablets_by_range_per_table().begin(); > Do we want to keep a track of this information even if the flag "--enable_r Maybe add a todo if planning to address in future. http://gerrit.cloudera.org:8080/#/c/19931/11/src/kudu/master/placement_policy-test.cc File src/kudu/master/placement_policy-test.cc: http://gerrit.cloudera.org:8080/#/c/19931/11/src/kudu/master/placement_policy-test.cc@1066 PS11, Line 1066: ASSERT_LE(748 Curious as to how did we arrive at this range [748, 752]? http://gerrit.cloudera.org:8080/#/c/19931/11/src/kudu/master/placement_policy-test.cc@1441 PS11, Line 1441: 3100 nit: Should this be 3110? Also curious on what causes the deviation here from 3000 here and in the above cases? http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: http://gerrit.cloudera.org:8080/#/c/19931/10/src/kudu/tserver/ts_tablet_manager.h@222 PS10, Line 222: umLiveTabletsByRangePerT > Good point, I used the GetNumLiveTablets() method as inspiration here. That Maybe this will help: https://github.com/apache/kudu/blob/master/src/kudu/tablet/metadata.proto#L201 -- To view, visit http://gerrit.cloudera.org:8080/19931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9caeb8d5547e946bfeb152a99e1ec034c3fa0a0f Gerrit-Change-Number: 19931 Gerrit-PatchSet: 11 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Thu, 29 Jun 2023 20:04:27 +0000 Gerrit-HasComments: Yes
