Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20183 )
Change subject: [compile] fix a compile warning ...................................................................... Patch Set 3: Code-Review+2 > (1 comment) > > Thank you very much for your comment. I have made changes to the > code based on your suggestion, and I kindly ask you to confirm > whether this modification approach meets expectations. Thanks a lot for addressing my comment! Yes, the code in PS3 looks good to me. BTW, about this approach using pragmas: does it look good enough to you, or you think it's better to update the code without using pragmas? Just curious to get more input on this from people. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Thu, 20 Jul 2023 18:49:32 +0000 Gerrit-HasComments: No
