Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20183 )
Change subject: [compile] fix a compile warning ...................................................................... Patch Set 4: > In my opinion, using pragma statements to avoid compilation > warnings may be more concise, and it minimally invades the existing > code, which may be the best way. However, the downside of this > approach is that developers need to have enough development > experience, at least to understand the existence of this method of > fixing. By the way, I also searched for this fix only after your > suggestion. And it may cause confusion for some beginners when they > read this segment. Overall, I think this is a good approach, and I > will also use this method to fix similar issues in the future. > Thank you for teaching me this method. That makes sense to me. Thank you for the feedback! -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 21 Jul 2023 21:16:38 +0000 Gerrit-HasComments: No
