Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20300 )
Change subject: KUDU-3500 don't start operations timed out in prepare queue ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20300/2/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/20300/2/src/kudu/tablet/ops/write_op.cc@76 PS2, Line 76: ; nit: Maybe use .(fullstop) to be consistent with tablet_inject_latency_on_apply_write_op_ms above. http://gerrit.cloudera.org:8080/#/c/20300/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/20300/2/src/kudu/tserver/tablet_service.cc@1681 PS2, Line 1681: deadline What are your thoughts on storing this deadline in a member variable of kudu::tablet::OpState? In that way if we want to extend this to other type of ops in future we would be able to. -- To view, visit http://gerrit.cloudera.org:8080/20300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I202ce6b5e425439b50c0751d7f7406e69b8e751a Gerrit-Change-Number: 20300 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 02 Aug 2023 21:10:32 +0000 Gerrit-HasComments: Yes
