Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20300 )
Change subject: KUDU-3500 don't start operations timed out in prepare queue ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20300/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/20300/2/src/kudu/tserver/tablet_service.cc@1681 PS2, Line 1681: deadline > From the other side, maybe the deadline should be a member of WriteOp itsel I took another look into the code. The OpDriver takes care of all types of the operations, so there is no need to add the timeout in OpState to have this for any other type of operation. So, as of PS3 the deadline field seems to be at the right place, IIUC. Let me know if I'm missing something. -- To view, visit http://gerrit.cloudera.org:8080/20300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I202ce6b5e425439b50c0751d7f7406e69b8e751a Gerrit-Change-Number: 20300 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 05 Aug 2023 06:08:47 +0000 Gerrit-HasComments: Yes
