Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20300 )
Change subject: KUDU-3500 don't start operations timed out in prepare queue ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20300/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/20300/2/src/kudu/tserver/tablet_service.cc@1681 PS2, Line 1681: deadline > I though about that before opting out for the current approach implemented >From the other side, maybe the deadline should be a member of WriteOp itself? >I'm not quite sure, but it seems I'm missing some bigger picture here to >properly attribute the properties of various objects. At some point, the op's >driver seemed as a good place to keep the deadline for the operation (if set). -- To view, visit http://gerrit.cloudera.org:8080/20300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I202ce6b5e425439b50c0751d7f7406e69b8e751a Gerrit-Change-Number: 20300 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 03 Aug 2023 01:33:05 +0000 Gerrit-HasComments: Yes
