Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [ubuntu-22.04] tsan build will compile on ubuntu 22.04 ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/20336/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20336/1//COMMIT_MSG@7 PS1, Line 7: ubuntu-22.04 nit: thirdparty http://gerrit.cloudera.org:8080/#/c/20336/1//COMMIT_MSG@7 PS1, Line 7: tsan build will compile on ubuntu 22.04 nit: fix TSAN build on Ubuntu 22.04 http://gerrit.cloudera.org:8080/#/c/20336/1//COMMIT_MSG@15 PS1, Line 15: is handled correctly by clang > 14.0 Are you trying to say that -flto=auto isn't handled correctly by CLANG < 15.0? Please update this sentence to be clearer. http://gerrit.cloudera.org:8080/#/c/20336/1/thirdparty/patches/llvm-Address-D100645-comment-eliminate-double-stacksize-calc.patch File thirdparty/patches/llvm-Address-D100645-comment-eliminate-double-stacksize-calc.patch: PS1: Are there any actual functional changes in this patch? I'm just trying to understand: was the issue in calling GetAltStackSize() twice, so it returned different numbers each time? Or this patch doesn't actually fix anything? -- To view, visit http://gerrit.cloudera.org:8080/20336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5 Gerrit-Change-Number: 20336 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 09 Aug 2023 16:51:22 +0000 Gerrit-HasComments: Yes
