Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04 ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20336/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20336/3//COMMIT_MSG@18 PS3, Line 18: Altought nit: Although http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch File thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch: http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch@6 PS2, Line 6: > Ashwani, it's a patch file, and removing these spaces could break the patch My bad! didn't realise it before. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/20336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5 Gerrit-Change-Number: 20336 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 16 Aug 2023 08:16:02 +0000 Gerrit-HasComments: Yes
