Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04 ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20336/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20336/2//COMMIT_MSG@9 PS2, Line 9: There are 2 thing missing from llvm 11: For posterity, can you also add minimal error message that TSAN build throws? Sometimes the error string doesn't directly point to the underlying problem so having a record of error string associated with fix can be of help. http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch File thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch: http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch@6 PS2, Line 6: nit: Remove whitespaces here and at lines 15, 30. http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch@8 PS2, Line 8: // TODO(glider): Better to add information (commit id, gcc branch info, etc) about the patch if this fix is derived. -- To view, visit http://gerrit.cloudera.org:8080/20336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5 Gerrit-Change-Number: 20336 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 14 Aug 2023 15:30:24 +0000 Gerrit-HasComments: Yes
