Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20365 )
Change subject: KUDU-3504 Crash master on subprocess death ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/20365/11/src/kudu/subprocess/server.cc File src/kudu/subprocess/server.cc: http://gerrit.cloudera.org:8080/#/c/20365/11/src/kudu/subprocess/server.cc@109 PS11, Line 109: exit_on_failure > I meant the flag to control the behavior w.r.t. instantiation of Subprocess Done http://gerrit.cloudera.org:8080/#/c/20365/11/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: http://gerrit.cloudera.org:8080/#/c/20365/11/src/kudu/util/subprocess.cc@280 PS11, Line 280: load() > nit: AFAIK, the casting operators in the standard C++ library work with std Yea I thought so too, but apparently, it doesn't work with Substitute (which is why it's called only in Substitutes): No matching function for call to 'Substitute' /Users/abukor/src/kudu/src/kudu/gutil/strings/substitute.h:175:20: note: candidate function not viable: no known conversion from 'std::atomic<int>' to 'const internal::SubstituteArg' for 2nd argument -- To view, visit http://gerrit.cloudera.org:8080/20365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec516f3d684f152bd29874b60b810c526ee5a184 Gerrit-Change-Number: 20365 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 18 Aug 2023 05:31:49 +0000 Gerrit-HasComments: Yes
