Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20365 )
Change subject: KUDU-3504 Crash master on subprocess death ...................................................................... Patch Set 10: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20365/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20365/10//COMMIT_MSG@10 PS10, Line 10: In these cases, the master happily went on, but failed to authorize : requests. Maybe you could be more specific: "In case the ranger subprocess crashed, the master happily went on ...". Because for me it wasn't clear for the first reading what crashed. (or I'm just missing something and subprocess == ranger subprocess?) http://gerrit.cloudera.org:8080/#/c/20365/10/src/kudu/util/subprocess.h File src/kudu/util/subprocess.h: http://gerrit.cloudera.org:8080/#/c/20365/10/src/kudu/util/subprocess.h@213 PS10, Line 213: std::atomic<State> state_; : std::atomic<int> child_pid_; I saw your gerrit comment, that these make TSAN happy. Could you please add a small comment, why now we have to have it thread safe? (maybe the tsan error etc) -- To view, visit http://gerrit.cloudera.org:8080/20365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec516f3d684f152bd29874b60b810c526ee5a184 Gerrit-Change-Number: 20365 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 17 Aug 2023 16:39:12 +0000 Gerrit-HasComments: Yes
