Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20365 )

Change subject: KUDU-3504 Crash master on subprocess death
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20365/10//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20365/10//COMMIT_MSG@10
PS10, Line 10: crashed.  In these cases, the master happily went on, but failed 
to
             : authorize
> Maybe you could be more specific:
Done


http://gerrit.cloudera.org:8080/#/c/20365/10/src/kudu/util/subprocess.h
File src/kudu/util/subprocess.h:

http://gerrit.cloudera.org:8080/#/c/20365/10/src/kudu/util/subprocess.h@213
PS10, Line 213:   std::atomic<State> state_;
              :   std::atomic<int> child_pid_;
> I saw your gerrit comment, that these make TSAN happy.
Done



--
To view, visit http://gerrit.cloudera.org:8080/20365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec516f3d684f152bd29874b60b810c526ee5a184
Gerrit-Change-Number: 20365
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 17 Aug 2023 19:47:55 +0000
Gerrit-HasComments: Yes

Reply via email to