Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20270 )
Change subject: KUDU-3461 [client] Avoid impala crash by returning error if invalid tablet id found ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/20270/8//COMMIT_MSG Commit Message: PS8: Do scan token generation and usage of them in scan operations are affected as well? Does it make sense to add a test to verify related functionality as well, using similar test scenario to emulate a situation when one client tries to open a tablet for scanning that was dropped just after a token for a scan had been created? http://gerrit.cloudera.org:8080/#/c/20270/8/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: http://gerrit.cloudera.org:8080/#/c/20270/8/src/kudu/client/batcher.cc@505 PS8, Line 505: if (result.status.IsInvalidArgument()) { : result.result = RetriableRpcStatus::NON_RETRIABLE_ERROR; : return result; : } Please add a comment to explain what sort of errors this clause is about to handle, similar to the other clauses in this scope. -- To view, visit http://gerrit.cloudera.org:8080/20270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia09cf6fb1b1d10f1ad13a62b5c863bcd1e3ab26a Gerrit-Change-Number: 20270 Gerrit-PatchSet: 8 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Wed, 23 Aug 2023 22:07:05 +0000 Gerrit-HasComments: Yes
