Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20499 )

Change subject: [server] output information on OpenSSL version
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20499/1/src/kudu/security/tls_context.cc
File src/kudu/security/tls_context.cc:

http://gerrit.cloudera.org:8080/#/c/20499/1/src/kudu/security/tls_context.cc@652
PS1, Line 652: 0x10100000L
I think it would be better to have macro for this instead of a magic number 
used at several places.



--
To view, visit http://gerrit.cloudera.org:8080/20499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I435119a0949aa9b933b06c1cc51c85d084f3d214
Gerrit-Change-Number: 20499
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Thu, 21 Sep 2023 12:31:31 +0000
Gerrit-HasComments: Yes

Reply via email to