Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20499 )
Change subject: [server] log information on OpenSSL version ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/20499/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20499/1//COMMIT_MSG@7 PS1, Line 7: output > nit: "Log" Done http://gerrit.cloudera.org:8080/#/c/20499/1//COMMIT_MSG@11 PS1, Line 11: what actual version > nit: "what version" Done http://gerrit.cloudera.org:8080/#/c/20499/1/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: http://gerrit.cloudera.org:8080/#/c/20499/1/src/kudu/security/tls_context.cc@652 PS1, Line 652: 0x10100000L > I think it would be better to have macro for this instead of a magic number Just FYI: this isn't a magic number, but the standard way of expressing the version of the OpenSSL library. You could get more information on this from https://www.openssl.org/docs/man1.1.1/man3/OpenSSL_version.html The related Kudu code has been using this way of differentiating between compile-time version of the OpenSSL library from the beginning, so I'm not going to break this tradition in this patch. -- To view, visit http://gerrit.cloudera.org:8080/20499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I435119a0949aa9b933b06c1cc51c85d084f3d214 Gerrit-Change-Number: 20499 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2023 17:39:42 +0000 Gerrit-HasComments: Yes
