Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20499 )
Change subject: [server] log information on OpenSSL version ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20499/1/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: http://gerrit.cloudera.org:8080/#/c/20499/1/src/kudu/security/tls_context.cc@652 PS1, Line 652: 0x10100000L > I am aware that this isn't a magic number. What I meant was for uninitiate Maybe, but OpenSSL doesn't introduce macro aliases for their version numbers with well-defined structure. AFAIK, using macros and extra macro aliases doesn't help to catch typos, no: if there is some macro which isn't defined (e.g., a misprint when typing that would-be-macro for a particular version in the pre-processor clause), the pre-processor doesn't produce a warning since it's not supposed to. Due to the reasons above, I don't think that introducing macros for OpenSSL versions has any meaningful return-on-investment. Anyway, thank you for the feedback -- I appreciate that. -- To view, visit http://gerrit.cloudera.org:8080/20499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I435119a0949aa9b933b06c1cc51c85d084f3d214 Gerrit-Change-Number: 20499 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 22 Sep 2023 17:38:42 +0000 Gerrit-HasComments: Yes
