Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 )
Change subject: KUDU-3498 Scanner keeps alive in periodically ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client-test.cc@3090 PS8, Line 3090: // Set fault tolerance false to enable the scanner expired. : ASSERT_OK(scanner.data_->mutable_configuration()->SetFaultTolerant(false)); Why do we need to set fault tolerant false here? Does it affect whether the scanner expires? http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client-test.cc@3108 PS8, Line 3108: TestStopKeepAlivePeriodically Seems this test is for testing the functionality of the StopKeepAlivePeriodically() method. Could you also add a test that verifies the keep alive timer can automatically stop if all the required data has been retrieved from tablet servers? http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client-test.cc@3121 PS8, Line 3121: // Start the keepalive timer. This comment does not match the actual behavior in the following code. http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/8/src/kudu/client/client.h@2963 PS8, Line 2963: StopKeepAlivePeriodically nit: What about renaming it to 'StopKeepAliveTimer'? -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 8 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 26 Sep 2023 03:44:41 +0000 Gerrit-HasComments: Yes
