Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 )
Change subject: KUDU-3498 Scanner keeps alive in periodically ...................................................................... Patch Set 10: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/client-test.cc@3036 PS10, Line 3036: // It is expired. : if (s.IsNotFound()) { : has_expired_scan = true; : break; : } nit: I see in PS4, you use ASSERT_TRUE(s.IsNotFound) here. Why is this changed? Could we just sleep more time to make sure there must be a NotFound error? http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/client-test.cc@3049 PS10, Line 3049: time nit: timer http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/scanner-internal.h File src/kudu/client/scanner-internal.h: http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/scanner-internal.h@307 PS10, Line 307: It used to This is used to -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 27 Sep 2023 05:20:48 +0000 Gerrit-HasComments: Yes
