Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 )
Change subject: KUDU-3498 Scanner keeps alive in periodically ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/client-test.cc@3036 PS10, Line 3036: // It is expired. : if (s.IsNotFound()) { : has_expired_scan = true; : break; : } > nit: I see in PS4, you use ASSERT_TRUE(s.IsNotFound) here. Why is this chan In PS4, there is just one tablet and one server. Scanner is not expired at first time reading, but will be expired at next reading. But in this commit, there are multiple tablets and multiple servers, this scanner will read all tablets in multiple servers. Scanner is not expired at first time for a new tablet. http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/client-test.cc@3049 PS10, Line 3049: time > nit: timer Done http://gerrit.cloudera.org:8080/#/c/20282/12/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/12/src/kudu/client/client.h@2962 PS12, Line 2962: /// Stop keeping the current remote scanner alive periodically. > I see the timer will be stopped in HasMoreRows(), when will the newly added Yes, the timer will be stopped in HasMoreRows(). But we still need a interface to stop the timer manually. http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/scanner-internal.h File src/kudu/client/scanner-internal.h: http://gerrit.cloudera.org:8080/#/c/20282/10/src/kudu/client/scanner-internal.h@307 PS10, Line 307: This is us > This is used to Done -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 13 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Thu, 28 Sep 2023 08:57:54 +0000 Gerrit-HasComments: Yes
