Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20708 )
Change subject: [messenger] Initialize SASL proto name to principal ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20708/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/20708/1/src/kudu/rpc/messenger.cc@87 PS1, Line 87: auto principal = kudu::security::GetLoggedInUsernameFromKeytab(); : if (principal.has_value()) { : set_sasl_proto_name(principal.value()); : } nit: consider moving this into the initializer's list as well, so it would be ... sasl_proto_name_(security::GetLoggedInUsernameFromKeytab().value_or("kudu")), ... -- To view, visit http://gerrit.cloudera.org:8080/20708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8decbd0b3e54df42bb0b9b14fc5ec291cd70b8b Gerrit-Change-Number: 20708 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 16 Nov 2023 05:52:07 +0000 Gerrit-HasComments: Yes
