Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20708 )
Change subject: [messenger] Initialize SASL proto name to principal ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/20708/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20708/1//COMMIT_MSG@18 PS1, Line 18: ::~ServerBase(). : > Looking at changelist f4fa4d22f (the patch was about getting rid of ASAN wa This part was rewritten in a way that it is still called but instead of shut down, now it is called in the destructor. http://gerrit.cloudera.org:8080/#/c/20708/1/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/20708/1/src/kudu/integration-tests/security-itest.cc@878 PS1, Line 878: cluster_opts_.principal = "oryx"; > nit: this is used only once, so why to introduce a constant then? Even if Done http://gerrit.cloudera.org:8080/#/c/20708/1/src/kudu/integration-tests/security-itest.cc@888 PS1, Line 888: // Tablet servers need to be restarted in order to update their master list. : for (int i = 0; i < cluster_->num_tablet_servers(); i++) { : cluster_->tablet_server(i)->Shutdown( > Consider converting this into a 'for()' cycle, using ExternalMiniCluster::n Done http://gerrit.cloudera.org:8080/#/c/20708/1/src/kudu/integration-tests/security-itest.cc@892 PS1, Line 892: } : : // Run a smoke test to verify that the cluster is > ditto Done http://gerrit.cloudera.org:8080/#/c/20708/1/src/kudu/integration-tests/security-itest.cc@898 PS1, Line 898: : // Shut down the leader master to simulate recoverable error. : cluster_->leader_master() > It would be great to add a comment what's the reason of doing this. Done -- To view, visit http://gerrit.cloudera.org:8080/20708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8decbd0b3e54df42bb0b9b14fc5ec291cd70b8b Gerrit-Change-Number: 20708 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2023 19:02:47 +0000 Gerrit-HasComments: Yes
