Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20708 )
Change subject: [messenger] Initialize SASL proto name to principal ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20708/3//COMMIT_MSG Commit Message: PS3: nit: please keep lines in the description part under 72 characters each. You might find more context at https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines which is referred to by Kudu's upstream documentation https://kudu.apache.org/docs/contributing.html#_submitting_patches http://gerrit.cloudera.org:8080/#/c/20708/3/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/20708/3/src/kudu/master/auto_rebalancer.cc@179 PS3, Line 179: MessengerBuilder builder("auto-rebalancer"); : auto username = kudu::security::GetLoggedInUsernameFromKeytab(); : if (username.has_value()) { : builder.set_sasl_proto_name(username.value()); : } : RETURN_NOT_OK(std::move(builder).Build(&messenger_)); Does it make sense to make a similar change in the AutoLeaderRebalancerTask::Init() method implementation in auto_leader_rebalancer.cc? http://gerrit.cloudera.org:8080/#/c/20708/3/src/kudu/master/master_runner.cc File src/kudu/master/master_runner.cc: http://gerrit.cloudera.org:8080/#/c/20708/3/src/kudu/master/master_runner.cc@318 PS3, Line 318: auto username = kudu::security::GetLoggedInUsernameFromKeytab(); : if (username.has_value()) { : builder.set_sasl_proto_name(username.value()); : } nit for here and elsewhere: this might be modernized a bit to avoid polluting the outer scope with non-relevant variables using std::opt::operator bool() if (auto username = security::GetLoggedInUsernameFromKeytab()) { builder.set_sasl_proto_name(username.value()); } -- To view, visit http://gerrit.cloudera.org:8080/20708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8decbd0b3e54df42bb0b9b14fc5ec291cd70b8b Gerrit-Change-Number: 20708 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2023 02:10:17 +0000 Gerrit-HasComments: Yes
