Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 )
Change subject: KUDU-3526 [java] Scanner should bound with a tserver in java client. ...................................................................... Patch Set 7: (4 comments) I wanted to ask for a test, just to encapsulate the initial problem, when the leader changes. I did a quick search, and found one Java test, which uses leader_step_down: https://github.com/apache/kudu/blob/master/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java#L241-L263 Using this example, do you think you can add a test which reproduceses the original issue? Thanks! http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@9 PS7, Line 9: by java nit: by the Java http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@10 PS7, Line 10: does not bound with the : tserver which it first communicates with. nit: is not bound to the tserver with which it first communicates. http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@16 PS7, Line 16: response nit: respond http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@19 PS7, Line 19: We should make the scanner bound with the tserver, like how it does : in c++ client. nit: We should bind the scanner to the tserver, similar to how it is done in the C++ client. -- To view, visit http://gerrit.cloudera.org:8080/20715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cf65f4215e99198dd41b43d14e50c8c23b8a9b2 Gerrit-Change-Number: 20715 Gerrit-PatchSet: 7 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2023 11:38:52 +0000 Gerrit-HasComments: Yes
