Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 )
Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. ...................................................................... Patch Set 8: (4 comments) > Patch Set 7: > > (4 comments) > > I wanted to ask for a test, just to encapsulate the initial problem, when the > leader changes. > > I did a quick search, and found one Java test, which uses leader_step_down: > https://github.com/apache/kudu/blob/master/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java#L241-L263 > Using this example, do you think you can add a test which reproduceses the > original issue? > > Thanks! Thank you for the review! I have added a unit test which will fail without the fix. Could you please help me review this again? Thanks! http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@9 PS7, Line 9: by the > nit: by the Java Done http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@10 PS7, Line 10: does not bound with the : tserver with which it first communicates. > nit: is not bound to the tserver with which it first communicates. Done http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@16 PS7, Line 16: respond > nit: respond Done http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@19 PS7, Line 19: We should bind the scanner to the tserver, similar to how it is done : in the C++ cli > nit: We should bind the scanner to the tserver, similar to how it is done i Done -- To view, visit http://gerrit.cloudera.org:8080/20715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cf65f4215e99198dd41b43d14e50c8c23b8a9b2 Gerrit-Change-Number: 20715 Gerrit-PatchSet: 8 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2023 07:27:45 +0000 Gerrit-HasComments: Yes
