Marton Greber has posted comments on this change. (
http://gerrit.cloudera.org:8080/20715 )
Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java
client.
......................................................................
Patch Set 11:
(2 comments)
Thanks for adding the requested test!
Just to be picky, I changed back the line which was causing the error:
@@ -1325,7 +1325,8 @@ public class AsyncKuduClient implements AutoCloseable {
// Important to increment the attempts before the next if statement since
// getSleepTimeForRpc() relies on it if the client is null or dead.
nextRequest.attempt++;
- final ServerInfo info = tablet.getTabletServerByUuid(scanner.getTsUUID());
+ final ServerInfo info =
tablet.getReplicaSelectedServerInfo(nextRequest.getReplicaSelection(),
+ location);
Build and run the test, but I dont get any errors. Did I miss something?
Just wanna make sure that the test fails - repros the issue.
http://gerrit.cloudera.org:8080/#/c/20715/11/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java:
http://gerrit.cloudera.org:8080/#/c/20715/11/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@636
PS11, Line 636: Restart
nit: Step down
right? ie the command you are building below is kudu tablet leader_step_down
http://gerrit.cloudera.org:8080/#/c/20715/11/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@657
PS11, Line 657: LOG.debug("Scaned " + kuduScanner.nextRows().numRows);
Rather than just logging it, could you please add assertions, that we dont get
'scanner not found' error?
--
To view, visit http://gerrit.cloudera.org:8080/20715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cf65f4215e99198dd41b43d14e50c8c23b8a9b2
Gerrit-Change-Number: 20715
Gerrit-PatchSet: 11
Gerrit-Owner: Song Jiacheng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Song Jiacheng <[email protected]>
Gerrit-Comment-Date: Tue, 12 Dec 2023 13:52:51 +0000
Gerrit-HasComments: Yes
