Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 )
Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. ...................................................................... Patch Set 20: (1 comment) > Patch Set 20: Code-Review+1 > > (1 comment) > > Thanks for fixing this issue! The changes overall look good to me. Thanks for the review! http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/ts_tablet_manager.cc@1794 PS20, Line 1794: for (const auto& entry : tablet_map_) { : if (entry.second->data_state() == tablet::TABLET_DATA_TOMBSTONED) { : to_report.push_back(entry.second); : } : } > nit: To avoid iterating all tablets on a tablet server, maybe we can call ' After the replica gets tombstoned, there might be very long time before its tablet is deleted and it should be deleted. So I think if we call 'MarkTabletDirty' when replica is tombstoned, the tombstoned replica will only be reported in the next heartbeat, when the tablet mostly still exists. We are iterating all the tablets every 6 hours by default. I think this overhead could be acceptable. -- To view, visit http://gerrit.cloudera.org:8080/20600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b Gerrit-Change-Number: 20600 Gerrit-PatchSet: 20 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 23 Nov 2023 06:28:18 +0000 Gerrit-HasComments: Yes
